Google + 1 and PhpBB3

Post by **Terr0r** » 11 Aug 2011, 13:11

it is about there are many many js files of this

<!-- IF SCRIPT_NAME == "viewtopic" or SCRIPT_NAME == "viewforum" -->
<script type="text/javascript" src="https://apis.google.com/js/plusone.js"></script>
<!-- ENDIF -->

state in the overall_header.html

and no one of the js files state in the overall_footer.html that is why it is loading better and faster

Post by **Stoker** » 11 Aug 2011, 13:16

By placing it in the footer the entire site will load before the script.
The you wont notice the load from the script.

Post by **Vox Populi** » 12 Aug 2011, 15:33

It did not make much difference via the footer or header. Very slight at the most.

Heads up for others. This snippet works in Subsilver2 styles also. Logged in as an admin or moderator it's a bit ugly as its just a hair above the Mod Panel link and it crowds it a bit but it's fine for regular users.

Post by **Stoker** » 12 Aug 2011, 15:41

This is how it looks for me:

ss.png

Post by **Vox Populi** » 12 Aug 2011, 15:48

It looks like that for me too but in a subsilver 2 style it looks like this (not to the regular user though). I'll tidy it up later.

Screenshot_1.png

Trust me. I don't use Subsilver anything but this here on my site for those that do which is currently ZERO.

Post by **Stoker** » 12 Aug 2011, 15:50

Oh, subsilver2. Edits probably have to be tweaked a bit.

Post by **neuropass** » 27 Sep 2011, 19:08

it does not pass the xhtml validation though. to pass the validation you need to escape the edits with java script.

Post by **Nully** » 27 Sep 2011, 19:58

Hello,
what do you mean by "escape the edits with java script" ?

Post by **Stoker** » 29 Sep 2011, 05:37

Neuropass is wrong, this version validates just fine

Post by **Nully** » 29 Sep 2011, 10:25

Fine.
It works! It is validated by W3C.

It seams fast also, meanwhile I have 2 others scripts (Google analytics and Tapatalk detect).
I inserted the code both in overall_footer of Prosilver and Prosilver_SE.