Google + 1 and PhpBB3

Mixed forum with code snippets, guides and styles
Forum rules
Everything in this forum is for everybody
But support only for Donators!
User avatar
Terr0r
BBCoder V
BBCoder V
Posts: 339
Joined: 04 May 2011, 00:47
BBCodes: 100
Location: The Netherlands
Contact:

Google + 1 and PhpBB3

Post by Terr0r »

it is about there are many many js files of this

Code: Select all

<!-- IF SCRIPT_NAME == "viewtopic" or SCRIPT_NAME == "viewforum" -->
<script type="text/javascript" src="https://apis.google.com/js/plusone.js"></script>
<!-- ENDIF -->
state in the overall_header.html

and no one of the js files state in the overall_footer.html that is why it is loading better and faster
If you can't fix it with ducktape you ain't using enough
For my MODS and BBCodes or other things that I have made take a look here
User avatar
Stoker
Site Admin
Site Admin
Posts: 3536
Joined: 12 May 2008, 23:26
BBCodes: 239
Favourite BBCode: Anipro
Favourite MOD: PrettyPhoto
Location: Denmark
Contact:

Google + 1 and PhpBB3

Post by Stoker »

By placing it in the footer the entire site will load before the script.
The you wont notice the load from the script.
Board rules! No PM support
User avatar
Vox Populi
BBCoder III
BBCoder III
Posts: 135
Joined: 27 Jul 2011, 15:44
BBCodes: 51
Favourite BBCode: YouTube
Favourite MOD: mChat, Welcome on Index
Location: Index,WA
Contact:

Google + 1 and PhpBB3

Post by Vox Populi »

It did not make much difference via the footer or header. Very slight at the most.

Heads up for others. This snippet works in Subsilver2 styles also. Logged in as an admin or moderator it's a bit ugly as its just a hair above the Mod Panel link and it crowds it a bit but it's fine for regular users.
Be who you are and say what you feel.
Those who mind don't matter.
Those who matter don't mind.
- Dr. Seuss
User avatar
Stoker
Site Admin
Site Admin
Posts: 3536
Joined: 12 May 2008, 23:26
BBCodes: 239
Favourite BBCode: Anipro
Favourite MOD: PrettyPhoto
Location: Denmark
Contact:

Google + 1 and PhpBB3

Post by Stoker »

This is how it looks for me:
ss.png
Board rules! No PM support
User avatar
Vox Populi
BBCoder III
BBCoder III
Posts: 135
Joined: 27 Jul 2011, 15:44
BBCodes: 51
Favourite BBCode: YouTube
Favourite MOD: mChat, Welcome on Index
Location: Index,WA
Contact:

Google + 1 and PhpBB3

Post by Vox Populi »

It looks like that for me too but in a subsilver 2 style it looks like this (not to the regular user though). I'll tidy it up later.
Subsilver2 Shot
Subsilver2 Shot
Trust me. I don't use Subsilver anything but this here on my site for those that do which is currently ZERO. :shock:
Be who you are and say what you feel.
Those who mind don't matter.
Those who matter don't mind.
- Dr. Seuss
User avatar
Stoker
Site Admin
Site Admin
Posts: 3536
Joined: 12 May 2008, 23:26
BBCodes: 239
Favourite BBCode: Anipro
Favourite MOD: PrettyPhoto
Location: Denmark
Contact:

Google + 1 and PhpBB3

Post by Stoker »

Oh, subsilver2. Edits probably have to be tweaked a bit.
Board rules! No PM support
User avatar
neuropass
BBCoder IV
BBCoder IV
Posts: 173
Joined: 11 Apr 2010, 02:33

Google + 1 and PhpBB3

Post by neuropass »

it does not pass the xhtml validation though. to pass the validation you need to escape the edits with java script. ;)
Modd it up! TweakScene ;-) Support us! || Follow us ||

Image
User avatar
Nully
Donator
Donator
Posts: 258
Joined: 15 Mar 2010, 00:03
BBCodes: 10
Favourite MOD: Radios
Location: France > Bulgaria
Contact:

Google + 1 and PhpBB3

Post by Nully »

Hello,
what do you mean by "escape the edits with java script" ?
User avatar
Stoker
Site Admin
Site Admin
Posts: 3536
Joined: 12 May 2008, 23:26
BBCodes: 239
Favourite BBCode: Anipro
Favourite MOD: PrettyPhoto
Location: Denmark
Contact:

Google + 1 and PhpBB3

Post by Stoker »

Neuropass is wrong, this version validates just fine ;)
Board rules! No PM support
User avatar
Nully
Donator
Donator
Posts: 258
Joined: 15 Mar 2010, 00:03
BBCodes: 10
Favourite MOD: Radios
Location: France > Bulgaria
Contact:

Google + 1 and PhpBB3

Post by Nully »

Fine.
It works! It is validated by W3C.

It seams fast also, meanwhile I have 2 others scripts (Google analytics and Tapatalk detect).
I inserted the code both in overall_footer of Prosilver and Prosilver_SE.
Post Reply