Page 2 of 3
Google + 1 and PhpBB3
Posted: 11 Aug 2011, 15:11
by Terr0r
it is about there are many many js files of this
Code: Select all
<!-- IF SCRIPT_NAME == "viewtopic" or SCRIPT_NAME == "viewforum" -->
<script type="text/javascript" src="https://apis.google.com/js/plusone.js"></script>
<!-- ENDIF -->
state in the overall_header.html
and no one of the js files state in the overall_footer.html that is why it is loading better and faster
Google + 1 and PhpBB3
Posted: 11 Aug 2011, 15:16
by Stoker
By placing it in the footer the entire site will load before the script.
The you wont notice the load from the script.
Google + 1 and PhpBB3
Posted: 12 Aug 2011, 17:33
by Vox Populi
It did not make much difference via the footer or header. Very slight at the most.
Heads up for others. This snippet works in Subsilver2 styles also. Logged in as an admin or moderator it's a bit ugly as its just a hair above the Mod Panel link and it crowds it a bit but it's fine for regular users.
Google + 1 and PhpBB3
Posted: 12 Aug 2011, 17:41
by Stoker
This is how it looks for me:
Google + 1 and PhpBB3
Posted: 12 Aug 2011, 17:48
by Vox Populi
It looks like that for me too but in a subsilver 2 style it looks like this (not to the regular user though). I'll tidy it up later.
- Subsilver2 Shot
Trust me. I don't use Subsilver anything but this here on my site for those that do which is currently ZERO.
Google + 1 and PhpBB3
Posted: 12 Aug 2011, 17:50
by Stoker
Oh, subsilver2. Edits probably have to be tweaked a bit.
Google + 1 and PhpBB3
Posted: 27 Sep 2011, 21:08
by neuropass
it does not pass the xhtml validation though. to pass the validation you need to escape the edits with java script.
Google + 1 and PhpBB3
Posted: 27 Sep 2011, 21:58
by Nully
Hello,
what do you mean by "escape the edits with java script" ?
Google + 1 and PhpBB3
Posted: 29 Sep 2011, 07:37
by Stoker
Neuropass is wrong, this version validates just fine
Google + 1 and PhpBB3
Posted: 29 Sep 2011, 12:25
by Nully
Fine.
It works! It is validated by W3C.
It seams fast also, meanwhile I have 2 others scripts (Google analytics and Tapatalk detect).
I inserted the code both in overall_footer of Prosilver and Prosilver_SE.