Top Stats

[doktornotor]

When submitting mods on phpbb.com latest jquery must be used.

You'd better update it to 1.7 then (I wonder, anyone submitted the mChat send button b0rkage bug to jQuery folks yet? Because it is still broken.)

[Stoker]

You'd better update it to 1.7 then

Dammit

[doktornotor]

Dammit

LOL... Still makes me wonder, would not using the CDN and latest make more sense... (not that it would make any difference when it comes to the pretty much dead validation queue).

Wrt the PEBKAC issues (jQuery included zillion times), it would really help if everyone using jQuery in their mods started using this:

Code: Select all

if (typeof jQuery == 'undefined')
{ 
    // not loaded, go load it here
} else {
    // already loaded, do not load again
}

[Stoker]

Using remote scripts in mods wont get accepted. So thats a dead end.
The idea is good though.

[doktornotor]

Using remote scripts in mods wont get accepted. So thats a dead end.

For validation? Yeah, I know... however, looking at the "progress" when it comes to mods validation over there @phpbb.com, I have serious doubts about the whole idea of validation, as it stands... there simply is stuff that is not worth getting validated at all, since - unless the scripts are remote - they break more quickly than the mods get validated. (Think, Facebook, +1 and similar kind of stuff.) For MODs having some ACP configuration, a checkbox to use either the CDN or the local version (could be the default) would make sense regardless. (No idea whether it would get validated if done that way or not, and frankly I do not care.)

</offtopic>

Wrt the multiple jQ etc. includes check - yeah, for sure, but needs some effort to get this pushed elsewhere - among other mods I am using, mChat using jQuery, Hotschi's Download MOD using this as well for some image-related stuff... worst of all, there are tons of those "in development" mods using this. Hard to even track where this stuff is used since there is no standard location for JS stuff.

[Arnevb]

I got some serious trouble with jQuery, I think it's completely messed up, altough I don't use mChat ot any other mods requiring jQuery. But i'm going to install this mod soon on a test board. Thanks for sharing, Stoker!

[Stoker]

Updated to version 1.0.3

New in this version:

• ACP Control for enable/disable features
• Option for number of displayed objects
• Jquery Scroll option

[doktornotor]

So, back to the jQuery check... Changed the mod to use this in overall_header.html

Code: Select all

<script type="text/javascript">
if (typeof jQuery == 'undefined') {
    document.write(unescape('%3Cscript src="{ROOT_PATH}script/jquery-1.7.min.js" type="text/javascript"%3E%3C/script%3E'));
}
</script>

Works nicely.

[martin123456]

So, back to the jQuery check... Changed the mod to use this in overall_header.html

Code: Select all

<script type="text/javascript">
if (typeof jQuery == 'undefined') {
    document.write(unescape('%3Cscript src="{ROOT_PATH}script/jquery-1.7.min.js" type="text/javascript"%3E%3C/script%3E'));
}
</script>

Works nicely.

Neat little trick ty

[doktornotor]

Some more bugs noted here

Additionally, there is a bunch of bugs in the subsilver2 recent_active_body.html template, a redundant </td> and unclosed <img> tag... Posting a fixed one here:

Code: Select all

<!-- Start Recent Active Topics -->
<table class="tablebg" cellspacing="1" width="100%">
<tr>
	<th colspan="2">&nbsp;{L_RECENT_ACTIVE}&nbsp;</th>
	<th width="50">&nbsp;{L_REPLIES}&nbsp;</th>
	<th width="50">&nbsp;{L_VIEWS}&nbsp;</th>
	<th>&nbsp;{L_LAST_POST}&nbsp;</th>
</tr>
<!-- BEGIN recent_active -->
		<tr>
			<td class="row1" width="50" align="center"><img src="{ROOT_PATH}images/starimg.png" width="27" height="27" alt="" /></td>
			<td class="row1" width="100%">
				<a class="forumlink" href="{recent_active.U_FIRST_TOPIC}">{recent_active.TOPIC_TITLE}</a>
				<p class="forumdesc">{L_POST_BY_AUTHOR} <a style="font-weight:bold; color: #{recent_active.TOPIC_FIRST_POSTER_COLOUR};" href="{recent_active.USERNAME_FIRST}">{recent_active.TOPIC_FIRST_POSTER_NAME}</a> {recent_active.TOPIC_TIME}</p>
			</td>
			<td class="row2" align="center"><p class="topicdetails">{recent_active.TOPIC_REPLIES}</p></td>
			<td class="row2" align="center"><p class="topicdetails">{recent_active.TOPIC_VIEWS}</p></td>
			<td class="row2" align="center" nowrap="nowrap">
					<p class="topicdetails">{recent_active.TOPIC_LAST_POST_TIME}</p>
					<p class="topicdetails"><a style="font-weight:bold; color: #{recent_active.TOPIC_LAST_POSTER_COLOUR};" href="{recent_active.USERNAME_LAST}">{recent_active.TOPIC_LAST_POSTER_NAME}</a> <a href="{recent_active.U_LAST_TOPIC}">{LAST_POST_IMG}</a>
					</p>
			</td>
		</tr>
<!-- END recent_active -->
</table>
<br />
<!-- End Recent Active Topics -->