Page 1 of 2

£ vs $

Posted: 18 Apr 2012, 01:05
by martin123456
Not really sure if this is donation mod or forum goal related

Here on this site you show the $ sign in the forum goals i too can show the same sign but if i want to show the £ then the forum goals shows ??

as below

Total donations 1000.000 ??

my donation mod setting are set at £ GBR but the forum goals donation bar will not show the £ for my country ?

Bug or not ?

£ vs $

Posted: 19 Apr 2012, 08:21
by Stoker
Thanks for reporting.
I will look into it later when I get more time.

£ vs $

Posted: 19 Apr 2012, 08:27
by Solidjeuh
try this in the template £
this should make the £ sign

open: forum_goal_body.html

Find:
{DONATION_GOAL_CURRENCY}

Replace with:
£

~~~~~~~~~~

Find:
{DONATION_GOAL_CURRENCY}

Replace with:
£

More symbols: http://www.w3schools.com/tags/ref_entities.asp

£ vs $

Posted: 19 Apr 2012, 12:22
by martin123456
Solidjeuh wrote:try this in the template £
this should make the £ sign

open: forum_goal_body.html

Find:
{DONATION_GOAL_CURRENCY}

Replace with:
£

~~~~~~~~~~

Find:
{DONATION_GOAL_CURRENCY}

Replace with:
£

More symbols: http://www.w3schools.com/tags/ref_entities.asp
this sort of fix's it.

it fixed the forum_goal_body.html ;) but in fixing that it screwed the donate_body.html up but with a bit of work i now have that showing perfect the only downfall is the currency selector in the acp is now not used as its hard coded into the html files also on a side note we dont show our funds like many countries do we show as

£25 as most show as 25$

here is how to get it to show in uk money for any other english sites

Donate_body.html

Code: Select all

<!-- INCLUDE overall_header.html --><h2>{L_DONATION_TITLE_HEAD} {SITENAME}</h2><div class="panel">   <div class="inner"><span class="corners-top"><span></span></span>		<!-- IF DONATION_GOAL_ENABLE and DONATION_ACHIEVEMENT_ENABLE and DONATION_GOAL > 0 -->		<div style="background:url('{ROOT_PATH}images/prog_grey.png') repeat-x; background-color: #cccccc; border: 1px solid black; width:100%; margin-top: 2px;"><div style="background:url('{ROOT_PATH}images/prog_<!-- IF DONATION_GOAL_NUMBER < 34 -->red<!-- ELSEIF DONATION_GOAL_NUMBER < 67 -->yellow<!-- ELSE -->green<!-- ENDIF -->.png') repeat-x;background-color: #008040; color: white; font-weight:bold; max-width:100%;<!-- IF DONATION_GOAL_NUMBER < 100 --> border-right: 1px solid black;<!-- ENDIF -->  width:{DONATION_GOAL_NUMBER}%; height:24px;"><span style="padding-left:25px; font-size:18px;">{DONATION_GOAL_NUMBER}%</span></div></div>		<!-- ENDIF -->		<!-- IF DONATION_ACHIEVEMENT_ENABLE or DONATION_GOAL_ENABLE -->		<p style="margin-top:10px; font-size:1.5em; text-align:center;"><!-- IF DONATION_ACHIEVEMENT_ENABLE -->{L_WE_HAVE_ACHIEVED} <strong><!-- IF DONATION_ACHIEVEMENT > 0 -->&pound;{DONATION_ACHIEVEMENT}<!-- ELSE -->{DONATION_GOAL_NUMBER}<!-- ENDIF --></strong><!-- IF DONATION_GOAL_CURRENCY_ENABLE --> <!-- ENDIF --> {L_WE_HAVE_ACHIEVED_IN}<!-- ENDIF --><!-- IF DONATION_GOAL_ENABLE and DONATION_GOAL > 0 --> {L_OUR_DONATION_GOAL} <strong>&pound;{DONATION_GOAL}</strong><!-- IF DONATION_GOAL_CURRENCY_ENABLE --> <!-- ENDIF -->.<!-- ENDIF --></p><hr />		<!-- ENDIF -->		<!-- IF DONATION_BODY -->{DONATION_BODY}<!-- ELSE --><p>{L_DONATION_BODY_DEFAULT}</p><!-- IF U_ACP --><p><em>{L_DONATION_ADMIN_DEFAULT}</em></p><!-- ENDIF --><!-- ENDIF -->   <span class="corners-bottom"><span></span></span></div></div><div class="panel">   <div class="inner"><span class="corners-top"><span></span></span>	<div style="text-align:center; padding-top:6px;">				<form action="https://www.paypal.com/cgi-bin/webscr" method="post">		<div>		<input type="hidden" name="cmd" value="_xclick" />		<input type="hidden" name="business" value="{DONATION_EMAIL}" />		<input type="hidden" name="item_name" value="{L_DONATION_TITLE} {SITENAME}" />		<input type="hidden" name="no_shipping" value="1" />		<input type="hidden" name="return" value="{U_DONATE_SUCCESS}" />		<input type="hidden" name="cancel_return" value="{U_DONATE_CANCEL}" />		<input type="hidden" name="item_number" value="{S_USERNAME}" />		<input type="hidden" name="tax" value="0" />		<input type="hidden" name="bn" value="PP-DonationsBF" />				<input type="text" name="amount" style="height:17px; font-size:12px;" class="inputbox autowidth" />		<select name="currency_code" id="currency_code">				<option value="GBP" selected="selected">{L_DONATION_GBP}</option>		<option value="USD" >{L_DONATION_USD}</option>		<option value="EUR">{L_DONATION_EUR}</option>		<option value="JPY">{L_DONATION_JPY}</option>		<option value="AUD">{L_DONATION_AUD}</option>		<option value="CAD">{L_DONATION_CAD}</option>		<option value="HKD">{L_DONATION_HKD}</option>		</select>		</div>		<fieldset id="contactpaypal" class="submit-buttons" style="margin-top:8px;">                    <input type="reset" class="button2" name="reset" value="{L_RESET}" />                    <input type="submit" class="button1" name="submit" value="{L_SUBMIT}" onclick="JavaScript:document.getElementById('contactpaypal').style.display='none';document.getElementById('processingpaypal').style.display='block';" />        </fieldset>		<fieldset id="processingpaypal" class="submit-buttons" style="margin-top:8px; display:none;">                    <img src="{ROOT_PATH}images/loader.gif" width="16" height="16" alt="" style="margin-bottom:-5px; padding-right:10px;" /> <input type="submit" class="button1" name="submit" value="{L_DONATION_CONTACT_PAYPAL}" />        </fieldset>		</form>	</div>   <span class="corners-bottom"><span></span></span></div></div><!-- INCLUDE overall_footer.html -->
forum_goal_body.html

Code: Select all

<!-- IF (DONATION_INDEX_ENABLE and S_DONATE_ENABLED and DONATION_INDEX_BOTTOM) and (DONATION_ACHIEVEMENT_ENABLE or DONATION_GOAL_ENABLE) -->
         <tr>
            <td style="width: 160px; font-size:12px;">{L_TOTAL_FORUM_DONATION_GOAL} <strong>&pound;{DONATION_GOAL}</strong> {DONATION_GOAL_CURRENCY}</td>
            <td style="width: 160px; font-size:12px;">{L_TOTAL_FORUM_DONATIONS} <strong>&pound;{DONATION_ACHIEVEMENT}</strong> {DONATION_GOAL_CURRENCY}</td>
            <td style="width: 160px; font-size:12px;"><!-- IF DONATION_GOAL_NUMBER < 100 -->&pound;{L_GOAL_REMAINING} <strong>&pound;{DONATION_GOAL_REST}</strong> {DONATION_GOAL_CURRENCY}<!-- ELSE --><em>{L_GOAL_REMAINING_ZERO}</em> <img src="{ROOT_PATH}images/forum_goal_ok.png" width="12" height="12" alt="" /><!-- ENDIF --></td>
            <td><div style="background:url('{ROOT_PATH}images/forum_goal_grey.png') repeat-x; background-color: #cccccc; border: 1px solid black; width:100%;"><div style="background:url('{ROOT_PATH}images/forum_goal_<!-- IF DONATION_GOAL_NUMBER < 34 -->red<!-- ELSEIF DONATION_GOAL_NUMBER < 67 -->yellow<!-- ELSEIF DONATION_GOAL_NUMBER < 101 -->green<!-- ELSEIF DONATION_GOAL_NUMBER > 100 -->blue<!-- ENDIF -->.png') repeat-x;background-color: #008040; color: white; font-weight:bold;<!-- IF DONATION_GOAL_NUMBER < 100 --> border-right: 1px solid black;<!-- ENDIF --> max-width:100%;  width:{DONATION_GOAL_NUMBER}%; height:12px;"><span style="padding-left:25px; font-size:10px; line-height:12px;">{DONATION_GOAL_NUMBER}%</span></div></div></td>
         </tr>
         <!-- ENDIF -->
Code edited and is w3c passed note the currency sign is in the right location for the uk

Demo: forum goal and donate.php
http://www.blades-place.com/index.php

http://www.blades-place.com/donate.php

£ vs $

Posted: 19 Apr 2012, 12:29
by martin123456
The above snips gives this
2.png
1.png

£ vs $

Posted: 05 May 2012, 08:11
by Stoker
&pound; in ACP will do the trick.

£ vs $

Posted: 05 May 2012, 13:55
by martin123456
Stoker wrote:&pound; in ACP will do the trick.
Tried that 1st time around and it failed (for me)

£ vs $

Posted: 05 May 2012, 14:05
by Stoker
Well, then wait for the next release. Its fixed ;)

£ vs $

Posted: 05 May 2012, 17:10
by martin123456
Stoker wrote:Well, then wait for the next release. Its fixed ;)
i fixed it on 19 Apr 2012 lmao :D

£ vs $

Posted: 05 May 2012, 17:25
by Stoker
Hardcoding the templates is not fixing ;)