[RC] Top Attachments

Modifications maintained and supported by all4phone
Forum rules
This forum is moderated by all4phone!
User avatar
martin123456
BBCoder VI
BBCoder VI
Posts: 765
Joined: 25 Jul 2011, 13:29
BBCodes: 34
Favourite MOD: Ban button
Location: Down south!
Contact:

[DEV] Top Attachments

Post by martin123456 »

The code i posted fix's this issue
12.gif
Here is a video to show the error better on your site and the fixed code on my site hope you understand what i'm trying to say.

http://www.blades-place.dyndns.info/border.wmv
User avatar
all4phone
BBCoder IV
BBCoder IV
Posts: 150
Joined: 11 Feb 2011, 13:50
BBCodes: 28
Favourite BBCode: Random text signature
Favourite MOD: BBCode Strikethrough MOD
Location: Poland
Contact:

[DEV] Top Attachments

Post by all4phone »

@martin123456, thanks for reporting (nice video).

What is the difference between your and mine code?

Code: Select all

<div class="topa_copy2">
               <li class="row">
                  <dl>
                     <dt class="topa_uinf">
                        <span class="topa_credit">{L_TOPA_CR}
                           <a href="#" title="{L_TOPA_CREDIT_1}"><div class="topa_cr1"></div></a>&nbsp;
                           <a href="#" title="{L_TOPA_CREDIT_2}"><div class="topa_cr1"></div></a>&nbsp;
                           <a href="#" title="{L_TOPA_CREDIT_3}"><div class="topa_cr2"></div></a>&nbsp;
                        </span>{TOPA_UINF}
                     </dt>
                  </dl>
               </li>
            </div> 

Code: Select all

<div class="topa_copy2">
                    <li class="row">
                        <dl>
                            <dt class="topa_uinf">
                                <span class="topa_credit">{L_TOPA_CR}
                                    <a href="#" title="{L_TOPA_CREDIT_1}"><div class="topa_cr1"></div></a>&nbsp;
                                    <a href="#" title="{L_TOPA_CREDIT_2}"><div class="topa_cr1"></div></a>&nbsp;
                                    <a href="#" title="{L_TOPA_CREDIT_3}"><div class="topa_cr2"></div></a>
                                </span>{TOPA_UINF}
                            </dt>
                        </dl>
                    </li>
                </div> 
One breaking space &nbsp;, am I right?
To be honest, I didn't notice this error in my browsers (IE, FF, Chrome).

Going forward, now I removed all spaces from this piece of code (on my board only) and it looks like :

Code: Select all

<div class="topa_copy2">
                    <li class="row">
                        <dl>
                            <dt class="topa_uinf">
                                <span class="topa_credit">{L_TOPA_CR}
                                    <a href="#" title="{L_TOPA_CREDIT_1}"><div class="topa_cr1"></div></a>
                                    <a href="#" title="{L_TOPA_CREDIT_2}"><div class="topa_cr1"></div></a>
                                    <a href="#" title="{L_TOPA_CREDIT_3}"><div class="topa_cr2"></div></a>
                                </span>{TOPA_UINF}
                            </dt>
                        </dl>
                    </li>
                </div> 
topa.css file I left without changes


Could you please check again on my site, whether the error is still exist ?
If so, press Ctrl + F5 several times, please.
Let me know what happened, thanks.
User avatar
martin123456
BBCoder VI
BBCoder VI
Posts: 765
Joined: 25 Jul 2011, 13:29
BBCodes: 34
Favourite MOD: Ban button
Location: Down south!
Contact:

[DEV] Top Attachments

Post by martin123456 »

this line

Code: Select all

<a href="#" title="{L_TOPA_CREDIT_3}"><div class="topa_cr2"></div></a>
replace with

Code: Select all

<a href="#" title="{L_TOPA_CREDIT_3}"><div class="topa_cr2"></div></a>&nbsp;
i have it working perfect as you can see in the video.

still the same on your board on both styles se_square was ok but not now.
User avatar
all4phone
BBCoder IV
BBCoder IV
Posts: 150
Joined: 11 Feb 2011, 13:50
BBCodes: 28
Favourite BBCode: Random text signature
Favourite MOD: BBCode Strikethrough MOD
Location: Poland
Contact:

[DEV] Top Attachments

Post by all4phone »

Ok martin, tank you very much for your help.

Anyone else can confirm this error, please?
User avatar
martin123456
BBCoder VI
BBCoder VI
Posts: 765
Joined: 25 Jul 2011, 13:29
BBCodes: 34
Favourite MOD: Ban button
Location: Down south!
Contact:

[DEV] Top Attachments

Post by martin123456 »

Confirmed on fresh install of phpbb http://www.blades-place.dyndns.info/chat/index.php
User avatar
Sniper_E
BBCoder II
BBCoder II
Posts: 44
Joined: 04 Dec 2011, 06:30
BBCodes: 1
Contact:

[DEV] Top Attachments

Post by Sniper_E »

It's all looking good all4phone.

The only thing I saw was two titles were centered and the content below it was not.
I see now you have "4 MOST DOWNLOADED ATTACHMENTS" title in line with the content below it.
Your "LOCATED (TOPIC TITLE)" could be, not centered so it will line up with the content below it.

Nice work! Nice mod! :thumb:
No is NEVER an Option and NEVER is the only Option when it comes to Giving Up!
User avatar
all4phone
BBCoder IV
BBCoder IV
Posts: 150
Joined: 11 Feb 2011, 13:50
BBCodes: 28
Favourite BBCode: Random text signature
Favourite MOD: BBCode Strikethrough MOD
Location: Poland
Contact:

[DEV] Top Attachments

Post by all4phone »

Guys, thanks for reporting :) .
martin123456 wrote:Confirmed on fresh install of phpbb yourdomain.com • Index page
@martin123456, strange, I see no error on your board
martin.PNG
I think the divs inside <dt class="topa_uinf"> don't need extra breaking spaces, because I use float:right formatting for these divs, but I could be wrong.

@Sniper_E, to be precise, first column on the left isn't centered (title and content also). Last right column has title centered only (has formatting: text-align: center, content isn't.
Everything else should be centered. Thanks for your appreciation :)
User avatar
martin123456
BBCoder VI
BBCoder VI
Posts: 765
Joined: 25 Jul 2011, 13:29
BBCodes: 34
Favourite MOD: Ban button
Location: Down south!
Contact:

[DEV] Top Attachments

Post by martin123456 »

I added the missing &nbsp; to the file.
User avatar
all4phone
BBCoder IV
BBCoder IV
Posts: 150
Joined: 11 Feb 2011, 13:50
BBCodes: 28
Favourite BBCode: Random text signature
Favourite MOD: BBCode Strikethrough MOD
Location: Poland
Contact:

[DEV] Top Attachments

Post by all4phone »

First post updated to v 0.1.2

new:
- added ACP control attachments extension


new download
new screenshot
User avatar
martin123456
BBCoder VI
BBCoder VI
Posts: 765
Joined: 25 Jul 2011, 13:29
BBCodes: 34
Favourite MOD: Ban button
Location: Down south!
Contact:

[DEV] Top Attachments

Post by martin123456 »

Nice update

This part breaks W3C

Code: Select all

<div class="topa_copy2">
					<li class="row">
						<dl>
							<dt class="topa_uinf">
								<span class="topa_credit">{L_TOPA_CR}
									<a href="#" title="{L_TOPA_CREDIT_1}"><div class="topa_cr1"></div></a>
									<a href="#" title="{L_TOPA_CREDIT_2}"><div class="topa_cr2"></div></a>
									<a href="#" title="{L_TOPA_CREDIT_3}"><div class="topa_cr3"></div></a>
								</span>{TOPA_UINF}
							</dt>
						</dl>
					</li>
				</div>
Locked