Page 2 of 6

Re: Adsense for phpBB 3.1.X

Posted: 03 Jan 2015, 14:07
by ThumperTM
I will give a try. Thanks!

Re: Adsense for phpBB 3.1.X

Posted: 09 Jan 2015, 23:19
by CentaurAtlas
Hey,
I have a question regarding this part:

"Copy the entire contents of the repository to ext/stoker/ads/ and images to images".


Is that standard practice for extensions or should they be in this?

styles/all/theme/images/


I'm curious as to know the "right" answer for 3.1.x

Thanks!

Re: Adsense for phpBB 3.1.X

Posted: 10 Jan 2015, 07:22
by Stoker
CentaurAtlas wrote:Hey,
I have a question regarding this part:

"Copy the entire contents of the repository to ext/stoker/ads/ and images to images".


Is that standard practice for extensions or should they be in this?

styles/all/theme/images/


I'm curious as to know the "right" answer for 3.1.x

Thanks!
No, it isnt standard procedure.
But if I remember correct, I include the image with inline css which isnt standard procedure either.

Re: Adsense for phpBB 3.1.X

Posted: 11 Jan 2015, 08:10
by Deathbringer
can this be made so that people who donate dont have to see ads?

Re: Adsense for phpBB 3.1.X

Posted: 14 Jan 2015, 08:07
by Stoker
Deathbringer wrote:can this be made so that people who donate dont have to see ads?
Steve made a nice little installer to handle something like this. It was a permission and a template switch to display for certain groups.
Dont have the code any longer.

Re: Adsense for phpBB 3.1.X

Posted: 31 Jan 2015, 10:59
by cheaty
Stoker, thank you very much for this simple yet awesome extension. Works beautifully on my phpBB 3.1.2.

What I did to get the responsive ads working is:

Code: Select all

<!-- IF postrow.S_FIRST_ROW -->
<div class="panel" style="padding-top:0;padding-bottom:0;background-color:#ECF3F7;">
	Your adsense code goes here
</div>
<hr class="divider" />
<!-- ENDIF -->
i.e. leaving only the outer div and removing the "online" class from it - looks cleaner this way.


Now I'm wondering - how to put some ads in viewforum.php? Any thoughts?

Cheers,

Re: Adsense for phpBB 3.1.X

Posted: 31 Jan 2015, 14:06
by Stoker
You can take a look at viewforum_body.html and create an event file to do it. Pretty much the same way as in viewtopic.

Re: Adsense for phpBB 3.1.X

Posted: 14 Feb 2015, 02:24
by t0ast
im gonna give this a try, thanks!

quick question, can you interchange the size of ads? like if i want bigger ads (like in viewtopic) on the home page, can i do that?

Re: Adsense for phpBB 3.1.X

Posted: 14 Feb 2015, 06:05
by Stoker
You chose size for the ads when you create them so anything that fits your design.

Re: Adsense for phpBB 3.1.X

Posted: 16 Feb 2015, 17:07
by PostmanMsk
Hello Can I install your mod to version 3.0.11?